Messages in this thread | | | Date | Thu, 30 Jun 2022 09:01:47 +0200 | Subject | Re: [PATCH v1] Fix: SYNCOBJ TIMELINE Test failed. | From | "Das, Nirmoy" <> |
| |
On 6/29/2022 11:12 AM, Christian König wrote: > Am 29.06.22 um 08:02 schrieb jie1zhan: >> The issue cause by the commit : >> >> 721255b527(drm/syncobj: flatten dma_fence_chains on transfer). >> >> Because it use the point of dma_fence incorrectly >> >> Correct the point of dma_fence by fence array > > Well that patch is just utterly nonsense as far as I can see. > >> >> Signed-off-by: jie1zhan <jesse.zhang@amd.com> >> >> Reviewed-by: Christian König <christian.koenig@amd.com> >> >> Reviewed-by: Nirmoy Das <nirmoy.das@linux.intel.com> > > I have strong doubts that Nirmoy has reviewed this and I certainly > haven't reviewed it.
I haven't reviewed this either.
Nirmoy
> > Christian. > >> --- >> drivers/gpu/drm/drm_syncobj.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/drm_syncobj.c >> b/drivers/gpu/drm/drm_syncobj.c >> index 7e48dcd1bee4..d5db818f1c76 100644 >> --- a/drivers/gpu/drm/drm_syncobj.c >> +++ b/drivers/gpu/drm/drm_syncobj.c >> @@ -887,7 +887,7 @@ static int drm_syncobj_flatten_chain(struct >> dma_fence **f) >> goto free_fences; >> dma_fence_put(*f); >> - *f = &array->base; >> + *f = array->fences[0]; >> return 0; >> free_fences: >
| |