Messages in this thread | | | From | Andy Shevchenko <> | Date | Thu, 30 Jun 2022 23:42:28 +0200 | Subject | Re: [PATCH v2] lib/test_printf.c: fix clang -Wformat warnings |
| |
On Thu, Jun 30, 2022 at 9:59 PM Justin Stitt <justinstitt@google.com> wrote: > > changes from v1: > * moved NOWARN macro definition to a more appropriate location > * using __diag_ignore_all (thanks Nathan) > * using local scoping for code blocks instead of __VA_ARGS__ (thanks Nick) > * indented affected test cases (thanks Andy) > > Suggested-by: Andy Shevchenko <andy@kernel.org> > Suggested-by: Nathan Chancellor <nathan@kernel.org> > Suggested-by: Nick Desaulniers <ndesaulniers@google.com> > Signed-off-by: Justin Stitt <justinstitt@google.com>
Somehow you replaced the commit message with a changelog. On top of that, I didn't suggest anything important here, so to me it is considered as a credit in the changelog (see previous sentence as well).
-- With Best Regards, Andy Shevchenko
| |