lkml.org 
[lkml]   [2022]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v7 4/9] drm/virtio: Unlock reservations on dma_resv_reserve_fences() error
    Date
    Unlock reservations on dma_resv_reserve_fences() error to fix recursive
    locking of the reservations when this error happens.

    Cc: stable@vger.kernel.org
    Fixes: c8d4c18bfbc4 ("dma-buf/drivers: make reserving a shared slot mandatory v4")
    Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
    Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
    ---
    drivers/gpu/drm/virtio/virtgpu_gem.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/virtio/virtgpu_gem.c b/drivers/gpu/drm/virtio/virtgpu_gem.c
    index 580a78809836..7db48d17ee3a 100644
    --- a/drivers/gpu/drm/virtio/virtgpu_gem.c
    +++ b/drivers/gpu/drm/virtio/virtgpu_gem.c
    @@ -228,8 +228,10 @@ int virtio_gpu_array_lock_resv(struct virtio_gpu_object_array *objs)

    for (i = 0; i < objs->nents; ++i) {
    ret = dma_resv_reserve_fences(objs->objs[i]->resv, 1);
    - if (ret)
    + if (ret) {
    + virtio_gpu_array_unlock_resv(objs);
    return ret;
    + }
    }
    return ret;
    }
    --
    2.36.1
    \
     
     \ /
      Last update: 2022-06-30 22:09    [W:2.392 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site