Messages in this thread | | | Date | Thu, 30 Jun 2022 10:27:16 -0600 | From | Rob Herring <> | Subject | Re: [PATCH v3 1/2] of: unittest: Switch to use fwnode instead of of_node |
| |
On Wed, Jun 29, 2022 at 02:50:09PM +0300, Andy Shevchenko wrote: > GPIO library now accepts fwnode as a firmware node, so > switch the module to use it. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > v3: no changes > drivers/of/unittest.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c > index 7f6bba18c515..5a842dfc27e8 100644 > --- a/drivers/of/unittest.c > +++ b/drivers/of/unittest.c > @@ -1602,7 +1602,7 @@ static int unittest_gpio_probe(struct platform_device *pdev) > > platform_set_drvdata(pdev, devptr); > > - devptr->chip.of_node = pdev->dev.of_node; > + devptr->chip.fwnode = dev_fwnode(&pdev->dev);
Perhaps I want the DT test code to test using the of_node pointer. We do want that to work, right?
I'm really not a fan of fwnode'ifying things that are DT only. It's really pointless churn.
Rob
| |