lkml.org 
[lkml]   [2022]   [Jun]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 53/67] media: i2c: imx412: Fix power_off ordering
    Date
    From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>

    commit 9a199694c6a1519522ec73a4571f68abe9f13d5d upstream.

    The enable path does
    - gpio
    - clock

    The disable path does
    - gpio
    - clock

    Fix the order on the power-off path so that power-off and power-on have the
    same ordering for clock and gpio.

    Fixes: 9214e86c0cc1 ("media: i2c: Add imx412 camera sensor driver")
    Cc: stable@vger.kernel.org
    Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
    Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
    Reviewed-by: Daniele Alessandrelli <daniele.alessandrelli@intel.com>
    Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/media/i2c/imx412.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/media/i2c/imx412.c
    +++ b/drivers/media/i2c/imx412.c
    @@ -1040,10 +1040,10 @@ static int imx412_power_off(struct devic
    struct v4l2_subdev *sd = dev_get_drvdata(dev);
    struct imx412 *imx412 = to_imx412(sd);

    - gpiod_set_value_cansleep(imx412->reset_gpio, 1);
    -
    clk_disable_unprepare(imx412->inclk);

    + gpiod_set_value_cansleep(imx412->reset_gpio, 1);
    +
    return 0;
    }


    \
     
     \ /
      Last update: 2022-06-03 20:22    [W:4.212 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site