lkml.org 
[lkml]   [2022]   [Jun]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 40/53] dm integrity: fix error code in dm_integrity_ctr()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    commit d3f2a14b8906df913cb04a706367b012db94a6e8 upstream.

    The "r" variable shadows an earlier "r" that has function scope. It
    means that we accidentally return success instead of an error code.
    Smatch has a warning for this:

    drivers/md/dm-integrity.c:4503 dm_integrity_ctr()
    warn: missing error code 'r'

    Fixes: 7eada909bfd7 ("dm: add integrity target")
    Cc: stable@vger.kernel.org
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Reviewed-by: Mikulas Patocka <mpatocka@redhat.com>
    Signed-off-by: Mike Snitzer <snitzer@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/md/dm-integrity.c | 2 --
    1 file changed, 2 deletions(-)

    --- a/drivers/md/dm-integrity.c
    +++ b/drivers/md/dm-integrity.c
    @@ -4327,8 +4327,6 @@ try_smaller_buffer:
    }

    if (should_write_sb) {
    - int r;
    -
    init_journal(ic, 0, ic->journal_sections, 0);
    r = dm_integrity_failed(ic);
    if (unlikely(r)) {

    \
     
     \ /
      Last update: 2022-06-03 20:09    [W:4.068 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site