lkml.org 
[lkml]   [2022]   [Jun]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 09/34] ACPI: sysfs: Make sparse happy about address space in use
    Date
    From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

    commit bdd56d7d8931e842775d2e5b93d426a8d1940e33 upstream.

    Sparse is not happy about address space in use in acpi_data_show():

    drivers/acpi/sysfs.c:428:14: warning: incorrect type in assignment (different address spaces)
    drivers/acpi/sysfs.c:428:14: expected void [noderef] __iomem *base
    drivers/acpi/sysfs.c:428:14: got void *
    drivers/acpi/sysfs.c:431:59: warning: incorrect type in argument 4 (different address spaces)
    drivers/acpi/sysfs.c:431:59: expected void const *from
    drivers/acpi/sysfs.c:431:59: got void [noderef] __iomem *base
    drivers/acpi/sysfs.c:433:30: warning: incorrect type in argument 1 (different address spaces)
    drivers/acpi/sysfs.c:433:30: expected void *logical_address
    drivers/acpi/sysfs.c:433:30: got void [noderef] __iomem *base

    Indeed, acpi_os_map_memory() returns a void pointer with dropped specific
    address space. Hence, we don't need to carry out __iomem in acpi_data_show().

    Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
    Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
    Cc: dann frazier <dann.frazier@canonical.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/acpi/sysfs.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/acpi/sysfs.c
    +++ b/drivers/acpi/sysfs.c
    @@ -438,7 +438,7 @@ static ssize_t acpi_data_show(struct fil
    loff_t offset, size_t count)
    {
    struct acpi_data_attr *data_attr;
    - void __iomem *base;
    + void *base;
    ssize_t rc;

    data_attr = container_of(bin_attr, struct acpi_data_attr, attr);

    \
     
     \ /
      Last update: 2022-06-03 19:49    [W:2.845 / U:0.300 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site