lkml.org 
[lkml]   [2022]   [Jun]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 1/2] wireless: ray_cs: Utilize strnlen() in parse_addr()
On Fri, Jun 03, 2022 at 09:50:55AM -0700, Joe Perches wrote:
> On Fri, 2022-06-03 at 19:44 +0300, Andy Shevchenko wrote:
> > Instead of doing simple operations and using an additional variable on stack,
> > utilize strnlen() and reuse len variable.
> []
> > diff --git a/drivers/net/wireless/ray_cs.c b/drivers/net/wireless/ray_cs.c
> []
> > + while (len > 0) {
> > + if ((k = hex_to_bin(in_str[len--])) != -1)
> > out[i] = k;
> > else
> > return 0;
>
> could be reversed and unindented
>
> >
> > - if (j == 0)
> > + if (len == 0)
> > break;
> > - if ((k = hex_to_bin(in_str[j--])) != -1)
> > + if ((k = hex_to_bin(in_str[len--])) != -1)
> > out[i] += k << 4;
> > else
> > return 0;
>
> and here

It might be done as a follow up. Thanks!


--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2022-06-03 19:06    [W:0.878 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site