Messages in this thread | | | Subject | Re: [PATCH v1 1/2] wireless: ray_cs: Utilize strnlen() in parse_addr() | From | Joe Perches <> | Date | Fri, 03 Jun 2022 09:50:55 -0700 |
| |
On Fri, 2022-06-03 at 19:44 +0300, Andy Shevchenko wrote: > Instead of doing simple operations and using an additional variable on stack, > utilize strnlen() and reuse len variable. [] > diff --git a/drivers/net/wireless/ray_cs.c b/drivers/net/wireless/ray_cs.c [] > + while (len > 0) { > + if ((k = hex_to_bin(in_str[len--])) != -1) > out[i] = k; > else > return 0;
could be reversed and unindented
> > - if (j == 0) > + if (len == 0) > break; > - if ((k = hex_to_bin(in_str[j--])) != -1) > + if ((k = hex_to_bin(in_str[len--])) != -1) > out[i] += k << 4; > else > return 0;
and here
| |