lkml.org 
[lkml]   [2022]   [Jun]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] leds: Add leds-qcom-lpg entry to documentation table of contents
Date
Bagas Sanjaya <bagasdotme@gmail.com> writes:

> After merging linux-leds tree to the mainline [1], htmldocs build produces
> a new warning:
>
> checking consistency... /home/bagas/repo/linux-stable/Documentation/leds/leds-qcom-lpg.rst: WARNING: document isn't included in any toctree
>
> The warning above is because leds-qcom-lpg.rst is missing in the table of
> contents.
>
> Add the missing entry.

The fix is good but ...

> [1]: https://lore.kernel.org/all/20220531200619.GA8906@duo.ucw.cz/
>
> Fixes: e98a860f65428a ("leds: qcom-lpg: Require pattern to follow documentation")

...I'm confused as to why you used that commit for a Fixes: tag. It
touched the file in question but didn't add it in the first place; I
think 24e2d05d1b68 is the droid you're looking for.

jon

\
 
 \ /
  Last update: 2022-06-03 15:43    [W:0.091 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site