lkml.org 
[lkml]   [2022]   [Jun]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] dt-bindings: mtd: mxc-nand: Drop undocumented properties from example
Hi Rob, Marc,

robh@kernel.org wrote on Tue, 31 May 2022 10:05:15 -0500:

> On Fri, May 27, 2022 at 11:38:39AM +0200, Marc Kleine-Budde wrote:
> > On 25.05.2022 15:59:46, Rob Herring wrote:
> > > With unevaluatedProperties issues fixed, 'nand-bus-width' and
> > > 'nand-ecc-mode' are flagged as undocumented. Removing them from the example
> > > is the easiest solution to silence the warnings.
> > >
> > > Signed-off-by: Rob Herring <robh@kernel.org>
> >
> > At least the 'nand-bus-width' property is described in
> > "nand-controller.yaml" and the "mxc-nand.yaml" refers to it.
> >
> > | allOf:
> > | - $ref: "nand-controller.yaml"
> >
> > Is this ref broken?
>
> Nope, read my note below. 'nand-bus-width' is documented as a nand chip
> (child node) property, not a nand controller property.
>
>
> > regards,
> > Marc
> >
> > > ---
> > > These properties may be deprecated, but they are still widely used in
> > > bindings. They either need to be documented (and marked deprecated) or
> > > removed from current users (i.e. dts files).

I don't mind keeping them undocumented to encourage people to migrate
to a better description. For the record, in the past controllers and
devices where not separated in the description, hence we had NAND chip
specific properties landing in to the NAND controller description.

So I'm fine with the current approach.

Thanks,
Miquèl

\
 
 \ /
  Last update: 2022-06-03 15:41    [W:0.554 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site