lkml.org 
[lkml]   [2022]   [Jun]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2] phy: ti: j721e-wiz: Fix refcount leak in wiz_get_lane_phy_types
    Date
    of_get_child_by_name() returns a node pointer with refcount
    incremented, we should use of_node_put() on it when not need anymore.
    Add missing of_node_put() to avoid refcount leak.

    Fixes: 7ae14cf581f2 ("phy: ti: j721e-wiz: Implement DisplayPort mode to the wiz driver")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    ---
    changes in v2:
    - update Fixes tag.
    v1 Link: https://lore.kernel.org/r/20220602130906.18095-1-linmq006@gmail.com
    ---
    drivers/phy/ti/phy-j721e-wiz.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/phy/ti/phy-j721e-wiz.c b/drivers/phy/ti/phy-j721e-wiz.c
    index da546c35d1d5..c6b53d4f6643 100644
    --- a/drivers/phy/ti/phy-j721e-wiz.c
    +++ b/drivers/phy/ti/phy-j721e-wiz.c
    @@ -1113,6 +1113,7 @@ static int wiz_get_lane_phy_types(struct device *dev, struct wiz *wiz)
    ret = of_property_read_u32(subnode, "reg", &reg);
    if (ret) {
    of_node_put(subnode);
    + of_node_put(serdes);
    dev_err(dev,
    "%s: Reading \"reg\" from \"%s\" failed: %d\n",
    __func__, subnode->name, ret);
    @@ -1127,6 +1128,7 @@ static int wiz_get_lane_phy_types(struct device *dev, struct wiz *wiz)
    for (i = reg; i < reg + num_lanes; i++)
    wiz->lane_phy_type[i] = phy_type;
    }
    + of_node_put(serdes);

    return 0;
    }
    --
    2.25.1
    \
     
     \ /
      Last update: 2022-06-03 15:05    [W:3.038 / U:1.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site