lkml.org 
[lkml]   [2022]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [RFC PATCH 01/26] hugetlb: make hstate accessor functions const
    On Fri, Jun 24, 2022 at 05:36:31PM +0000, James Houghton wrote:
    > This is just a const-correctness change so that the new hugetlb_pte
    > changes can be const-correct too.
    >
    > Acked-by: David Rientjes <rientjes@google.com>
    >
    > Signed-off-by: James Houghton <jthoughton@google.com>

    This is a good start. I also want to make those helpers take
    const type parameter. Seems you have forgotten to update them
    when !CONFIG_HUGETLB_PAGE.

    Thanks.

    > ---
    > include/linux/hugetlb.h | 12 ++++++------
    > 1 file changed, 6 insertions(+), 6 deletions(-)
    >
    > diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
    > index e4cff27d1198..498a4ae3d462 100644
    > --- a/include/linux/hugetlb.h
    > +++ b/include/linux/hugetlb.h
    > @@ -715,7 +715,7 @@ static inline struct hstate *hstate_vma(struct vm_area_struct *vma)
    > return hstate_file(vma->vm_file);
    > }
    >
    > -static inline unsigned long huge_page_size(struct hstate *h)
    > +static inline unsigned long huge_page_size(const struct hstate *h)
    > {
    > return (unsigned long)PAGE_SIZE << h->order;
    > }
    > @@ -729,27 +729,27 @@ static inline unsigned long huge_page_mask(struct hstate *h)
    > return h->mask;
    > }
    >
    > -static inline unsigned int huge_page_order(struct hstate *h)
    > +static inline unsigned int huge_page_order(const struct hstate *h)
    > {
    > return h->order;
    > }
    >
    > -static inline unsigned huge_page_shift(struct hstate *h)
    > +static inline unsigned huge_page_shift(const struct hstate *h)
    > {
    > return h->order + PAGE_SHIFT;
    > }
    >
    > -static inline bool hstate_is_gigantic(struct hstate *h)
    > +static inline bool hstate_is_gigantic(const struct hstate *h)
    > {
    > return huge_page_order(h) >= MAX_ORDER;
    > }
    >
    > -static inline unsigned int pages_per_huge_page(struct hstate *h)
    > +static inline unsigned int pages_per_huge_page(const struct hstate *h)
    > {
    > return 1 << h->order;
    > }
    >
    > -static inline unsigned int blocks_per_huge_page(struct hstate *h)
    > +static inline unsigned int blocks_per_huge_page(const struct hstate *h)
    > {
    > return huge_page_size(h) / 512;
    > }
    > --
    > 2.37.0.rc0.161.g10f37bed90-goog
    >
    >

    \
     
     \ /
      Last update: 2022-06-29 08:20    [W:2.595 / U:1.884 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site