lkml.org 
[lkml]   [2022]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] remove CONFIG_ANDROID
    On Wed, Jun 29, 2022 at 06:30:07PM +0200, Christoph Hellwig wrote:
    > On Wed, Jun 29, 2022 at 06:25:32PM +0200, Jason A. Donenfeld wrote:
    > > Anyway, instead of the slow drip of "facts" and ≤three sentence emails,
    > > can you just write up a paragraph that indicates this is safe to do (for
    > > both (1) and (2)) in your v+1?
    >
    > Why would I care? If your config wakeups up so often that you need
    > special casing find a way to deal with it.

    You should care, because the change you're suggesting might break code
    that I maintain. If you don't care about breaking my code with your
    change, than just have my "nack", and it'll be up to Greg to decide
    whether he wants to apply this despite the nack for two separate
    affected code spots.

    On the technical topic, an Android developer friend following this
    thread just pointed out to me that Android doesn't use PM_AUTOSLEEP and
    just has userspace causing suspend frequently. So by his rough
    estimation your patch actually *will* break Android devices. Zoinks.
    Maybe he's right, maybe he's not -- I don't know -- but you should
    probably look into this if you want this patch to land without breakage.

    Jason

    \
     
     \ /
      Last update: 2022-06-29 18:41    [W:3.447 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site