lkml.org 
[lkml]   [2022]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/7] Staging: rtl8192e: Avoid multiple assignments
On Tue, Jun 28, 2022 at 10:30:52AM +0200, Felix Schlepper wrote:
> This addresses an issue raised by checkpatch.pl:
>
> $ ./scripts/checkpatch.pl --terse -f drivers/staging/rtl8192e/rtllib_wx.c
> CHECK: multiple assignments should be avoided
>
> This patch does not change the logical of the assignments.
>
> Signed-off-by: Felix Schlepper <f3sch.git@outlook.com>
> ---
> drivers/staging/rtl8192e/rtllib_wx.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192e/rtllib_wx.c b/drivers/staging/rtl8192e/rtllib_wx.c
> index 7bd1e829ff7e..c8fc66113b41 100644
> --- a/drivers/staging/rtl8192e/rtllib_wx.c
> +++ b/drivers/staging/rtl8192e/rtllib_wx.c
> @@ -160,7 +160,8 @@ static inline char *rtl819x_translate_scan(struct rtllib_device *ieee,
> max_rate = rate;
> }
> iwe.cmd = SIOCGIWRATE;
> - iwe.u.bitrate.fixed = iwe.u.bitrate.disabled = 0;
> + iwe.u.bitrate.disabled = 0;
> + iwe.u.bitrate.fixed = iwe.u.bitrate.disabled;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
This assignment makes no sense. Why are we setting fixed = disabled?
If you're going to split it apart do:

iwe.u.bitrate.disabled = 0;
iwe.u.bitrate.fixed = 0;

regards,
dan carpenter

\
 
 \ /
  Last update: 2022-06-29 18:14    [W:0.114 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site