Messages in this thread | | | Subject | Re: [PATCH RESEND v5 7/8] clk: baikal-t1: Add DDR/PCIe directly controlled resets support | From | Philipp Zabel <> | Date | Wed, 29 Jun 2022 17:16:56 +0200 |
| |
Hi Serge,
On Fr, 2022-06-24 at 17:18 +0300, Serge Semin wrote: > Aside with a set of the trigger-like resets Baikal-T1 CCU provides two > additional blocks with directly controlled reset signals. In particular it > concerns DDR full and initial resets and various PCIe sub-domains resets. > Let's add the direct reset assertion/de-assertion of the corresponding > flags support into the Baikal-T1 CCU driver then. It will be required at > least for the PCIe platform driver. Obviously the DDR controller isn't > supposed to be fully reset in the kernel, so the corresponding controls > are added just for the sake of the interface implementation completeness. > > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
This looks good to me, the issues with the previous patch still apply.
[...] > +static int ccu_rst_set(struct reset_controller_dev *rcdev, > + unsigned long idx, bool high) > +{ > + struct ccu_rst *rst; > + > + rst = ccu_rst_get_desc(rcdev, idx); > + if (IS_ERR(rst)) { > + pr_err("Invalid reset index %lu specified\n", idx); > + return PTR_ERR(rst); > + }
e.g. this should not be necessary.
regards Philipp
| |