Messages in this thread | | | Date | Wed, 29 Jun 2022 19:58:49 +0800 | From | kernel test robot <> | Subject | Re: [PATCH -next 2/2] PM: suspend: advanced pm_wakeup_clear() for normal suspend/hibernate |
| |
Hi xiongxin,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on next-20220628]
url: https://github.com/intel-lab-lkp/linux/commits/xiongxin/PM-suspend-Optimized-suspend-is-fail-returned-by-wakeup/20220629-114731 base: cb71b93c2dc36d18a8b05245973328d018272cdf config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20220629/202206291941.94EV5b6M-lkp@intel.com/config) compiler: sh4-linux-gcc (GCC) 11.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/2e0bc447b95996d1757038708bd6adf613f0b936 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review xiongxin/PM-suspend-Optimized-suspend-is-fail-returned-by-wakeup/20220629-114731 git checkout 2e0bc447b95996d1757038708bd6adf613f0b936 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=sh SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
kernel/power/process.c: In function 'freeze_processes': >> kernel/power/process.c:134:13: error: 'pm_suspend_target_state' undeclared (first use in this function) 134 | if (pm_suspend_target_state != PM_SUSPEND_ON) | ^~~~~~~~~~~~~~~~~~~~~~~ kernel/power/process.c:134:13: note: each undeclared identifier is reported only once for each function it appears in
vim +/pm_suspend_target_state +134 kernel/power/process.c
112 113 /** 114 * freeze_processes - Signal user space processes to enter the refrigerator. 115 * The current thread will not be frozen. The same process that calls 116 * freeze_processes must later call thaw_processes. 117 * 118 * On success, returns 0. On failure, -errno and system is fully thawed. 119 */ 120 int freeze_processes(void) 121 { 122 int error; 123 124 error = __usermodehelper_disable(UMH_FREEZING); 125 if (error) 126 return error; 127 128 /* Make sure this task doesn't get frozen */ 129 current->flags |= PF_SUSPEND_TASK; 130 131 if (!pm_freezing) 132 atomic_inc(&system_freezing_cnt); 133 > 134 if (pm_suspend_target_state != PM_SUSPEND_ON) 135 pm_wakeup_clear(1); 136 else 137 pm_wakeup_clear(0); 138 pr_info("Freezing user space processes ... "); 139 pm_freezing = true; 140 error = try_to_freeze_tasks(true); 141 if (!error) { 142 __usermodehelper_set_disable_depth(UMH_DISABLED); 143 pr_cont("done."); 144 } 145 pr_cont("\n"); 146 BUG_ON(in_atomic()); 147 148 /* 149 * Now that the whole userspace is frozen we need to disable 150 * the OOM killer to disallow any further interference with 151 * killable tasks. There is no guarantee oom victims will 152 * ever reach a point they go away we have to wait with a timeout. 153 */ 154 if (!error && !oom_killer_disable(msecs_to_jiffies(freeze_timeout_msecs))) 155 error = -EBUSY; 156 157 if (error) 158 thaw_processes(); 159 return error; 160 } 161
-- 0-DAY CI Kernel Test Service https://01.org/lkp
| |