Messages in this thread | | | Date | Wed, 29 Jun 2022 04:49:32 -0700 | Subject | Re: [PATCH v6 2/5] dt-bindings: clock: Add AST2500/AST2600 HACE reset definition | From | Dhananjay Phadke <> |
| |
On 6/29/2022 2:44 AM, Neal Liu wrote: > Add HACE reset bit definition for AST2500/AST2600. > > Signed-off-by: Neal Liu <neal_liu@aspeedtech.com> > Signed-off-by: Johnny Huang <johnny_huang@aspeedtech.com> > --- > include/dt-bindings/clock/aspeed-clock.h | 1 + > include/dt-bindings/clock/ast2600-clock.h | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/include/dt-bindings/clock/aspeed-clock.h b/include/dt-bindings/clock/aspeed-clock.h > index 9ff4f6e4558c..06d568382c77 100644 > --- a/include/dt-bindings/clock/aspeed-clock.h > +++ b/include/dt-bindings/clock/aspeed-clock.h > @@ -52,5 +52,6 @@ > #define ASPEED_RESET_I2C 7 > #define ASPEED_RESET_AHB 8 > #define ASPEED_RESET_CRT1 9 > +#define ASPEED_RESET_HACE 10
NAK.
I replied to older v5 of this patch, but this v6 also looks incorrect as per HW manual.
https://lore.kernel.org/linux-arm-kernel/20220629032008.1579899-1-neal_liu@aspeedtech.com/T/#m000bd3388b3e41117aa0eef10bf6f8a6a3a85cce
For both AST2400 and AST2500: SCU04[10] = PECI.
It will be best to refactor/split aspeed-clock.h into separate files.
Regards, Dhananjay
| |