lkml.org 
[lkml]   [2022]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3 2/4] dt-bindings: arm: msm: Convert kpss-acc driver Documentation to yaml
From
On 29/06/2022 12:40, Christian Marangi wrote:
> On Wed, Jun 29, 2022 at 08:14:12AM +0200, Krzysztof Kozlowski wrote:
>> On 28/06/2022 20:41, Christian Marangi wrote:
>>> Convert kpss-acc driver Documentation to yaml.
>>> The original Documentation was wrong all along. Fix it while we are
>>> converting it.
>>> The example was wrong as kpss-acc-v2 should only expose the regs but we
>>> don't have any driver that expose additional clocks. The kpss-acc driver
>>> is only specific to v1. For this exact reason, limit all the additional
>>> bindings (clocks, clock-names, clock-output-names and #clock-cells) to
>>> v1 and also flag that these bindings should NOT be used for v2.
>>>
>>> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
>>> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
>>
>> This is still not fixed and not tested. Since 4 versions of this
>> patchset (previously was part of other set).
>>
>> I retract my review. Please test the bindings.
>>
>> Best regards,
>> Krzysztof
>
> Thing is that I tested them and on my side I don't have such errors.

Then maybe update your dtschema because I can easily see them.

>
> I'm using the linux-next branch. Should I use something else that have
> newer schema files?
>
> Also on other patch there are some error reported that are unrelated to
> my change and that looks strange.

The other might be not be relevant, but this one is real and reproducible.

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-06-29 13:14    [W:0.085 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site