Messages in this thread | | | From | Yongji Xie <> | Date | Wed, 29 Jun 2022 17:28:55 +0800 | Subject | Re: [PATCH 6/6] vduse: Update api version to 1 |
| |
On Wed, Jun 29, 2022 at 5:22 PM Michael S. Tsirkin <mst@redhat.com> wrote: > > On Wed, Jun 29, 2022 at 05:02:40PM +0800, Yongji Xie wrote: > > On Wed, Jun 29, 2022 at 4:33 PM Michael S. Tsirkin <mst@redhat.com> wrote: > > > > > > On Wed, Jun 29, 2022 at 04:25:41PM +0800, Xie Yongji wrote: > > > > Let's update api version to 1 since we introduced > > > > some new ioctls to support registering userspace > > > > memory for IOTLB. > > > > > > > > Signed-off-by: Xie Yongji <xieyongji@bytedance.com> > > > > > > > > > Adding new ioctls does not justify things like this. > > > > > > > What I want to do here is make userspace know whether this feature is > > supported or not in the kernel. So do you think we need to add > > something like CHECK_EXTENSION ioctl here? > > Why bother? unsupported ioctls just return an error code. >
Oh, yes. I forgot the error code of the ioctls.
Thanks, Yongji
| |