lkml.org 
[lkml]   [2022]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] net: dsa: rzn1-a5psw: fix a NULL vs IS_ERR() check in a5psw_probe()
Le Tue, 28 Jun 2022 13:09:20 +0000,
Peng Wu <wupeng58@huawei.com> a écrit :

> The devm_platform_ioremap_resource() function never returns NULL.
> It returns error pointers.
>
> Signed-off-by: Peng Wu <wupeng58@huawei.com>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> ---
> drivers/net/dsa/rzn1_a5psw.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/dsa/rzn1_a5psw.c b/drivers/net/dsa/rzn1_a5psw.c
> index 3e910da98ae2..5b14e2ba9b79 100644
> --- a/drivers/net/dsa/rzn1_a5psw.c
> +++ b/drivers/net/dsa/rzn1_a5psw.c
> @@ -946,8 +946,8 @@ static int a5psw_probe(struct platform_device *pdev)
> mutex_init(&a5psw->lk_lock);
> spin_lock_init(&a5psw->reg_lock);
> a5psw->base = devm_platform_ioremap_resource(pdev, 0);
> - if (!a5psw->base)
> - return -EINVAL;
> + if (IS_ERR(a5psw->base))
> + return PTR_ERR(a5psw->base);
>
> ret = a5psw_pcs_get(a5psw);
> if (ret)

Thanks,

Reviewed-by: Clément Léger <clement.leger@bootlin.com>

--
Clément Léger,
Embedded Linux and Kernel engineer at Bootlin
https://bootlin.com

\
 
 \ /
  Last update: 2022-06-29 11:29    [W:0.033 / U:0.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site