Messages in this thread | | | From | David Gow <> | Date | Wed, 29 Jun 2022 17:05:57 +0800 | Subject | Re: [PATCH v2] Documentation: kunit: Cleanup run_wrapper, fix x-ref |
| |
On Wed, Jun 29, 2022 at 4:44 PM Bagas Sanjaya <bagasdotme@gmail.com> wrote: > > On 6/29/22 11:06, David Gow wrote: > > +This means that for most architectures, running under qemu is as simple as: > > + > > +.. code-block:: bash > > + > > + ./tools/testing/kunit/kunit.py run --arch=x86_64 > > + > > +When cross-compiling, we'll likely need to specify a different toolchain, for > > +example: > > + > > +.. code-block:: bash > > + > > + ./tools/testing/kunit/kunit.py run \ > > + --arch=s390 \ > > + --cross_compile=s390x-linux-gnu- > > + > > nit: s/we'll/you'll/ > > Otherwise looks OK.
Thanks. The rest of this document is using "we" rather than "you", so I used "we'll" for consistency. If "you" is preferred generally, it'd be best to change it throughout the document (probably in a separate patch).
Cheers, -- David [unhandled content-type:application/pkcs7-signature] | |