Messages in this thread | | | Date | Wed, 29 Jun 2022 09:36:23 +0200 | Subject | Re: [PATCH 4/8] watchdog: s3c2410_wdt: Remove #ifdef guards for PM related functions | From | Krzysztof Kozlowski <> |
| |
On 28/06/2022 21:34, Paul Cercueil wrote: > Use the new DEFINE_SIMPLE_DEV_PM_OPS() and pm_sleep_ptr() macros to > handle the .suspend/.resume callbacks. > > These macros allow the suspend and resume functions to be automatically > dropped by the compiler when CONFIG_SUSPEND is disabled, without having > to use #ifdef guards. Not using #ifdef guards means that the code is > always compiled independently of any Kconfig option, and thanks to that > bugs and regressions are easier to catch. > > Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards, Krzysztof
| |