Messages in this thread | | | Subject | Re: [PATCH v2 00/11] SMM emulation and interrupt shadow fixes | From | Maxim Levitsky <> | Date | Wed, 29 Jun 2022 10:21:45 +0300 |
| |
On Tue, 2022-06-21 at 18:08 +0300, Maxim Levitsky wrote: > This patch series is a result of long debug work to find out why > sometimes guests with win11 secure boot > were failing during boot. > > During writing a unit test I found another bug, turns out > that on rsm emulation, if the rsm instruction was done in real > or 32 bit mode, KVM would truncate the restored RIP to 32 bit. > > I also refactored the way we write SMRAM so it is easier > now to understand what is going on. > > The main bug in this series which I fixed is that we > allowed #SMI to happen during the STI interrupt shadow, > and we did nothing to both reset it on #SMI handler > entry and restore it on RSM. > > Best regards, > Maxim Levitsky > > Maxim Levitsky (11): > KVM: x86: emulator: em_sysexit should update ctxt->mode > KVM: x86: emulator: introduce update_emulation_mode > KVM: x86: emulator: remove assign_eip_near/far > KVM: x86: emulator: update the emulation mode after rsm > KVM: x86: emulator: update the emulation mode after CR0 write > KVM: x86: emulator/smm: number of GPRs in the SMRAM image depends on > the image format > KVM: x86: emulator/smm: add structs for KVM's smram layout > KVM: x86: emulator/smm: use smram struct for 32 bit smram load/restore > KVM: x86: emulator/smm: use smram struct for 64 bit smram load/restore > KVM: x86: SVM: use smram structs > KVM: x86: emulator/smm: preserve interrupt shadow in SMRAM > > arch/x86/include/asm/kvm_host.h | 6 - > arch/x86/kvm/emulate.c | 305 ++++++++++++++++---------------- > arch/x86/kvm/kvm_emulate.h | 146 +++++++++++++++ > arch/x86/kvm/svm/svm.c | 28 +-- > arch/x86/kvm/x86.c | 162 ++++++++--------- > 5 files changed, 394 insertions(+), 253 deletions(-) > > -- > 2.26.3 > > A very gentle ping on the patch series.
Best regards, Maxim Levitsky
| |