lkml.org 
[lkml]   [2022]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v6 08/22] drm/virtio: Unlock reservations on dma_resv_reserve_fences() error
    From

    On 5/27/22 01:50, Dmitry Osipenko wrote:
    > Unlock reservations on dma_resv_reserve_fences() error to fix recursive
    > locking of the reservations when this error happens.
    Fixes:
    > Cc: stable@vger.kernel.org

    With that fixed,

    Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>


    > Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
    > ---
    > drivers/gpu/drm/virtio/virtgpu_gem.c | 4 +++-
    > 1 file changed, 3 insertions(+), 1 deletion(-)
    >
    > diff --git a/drivers/gpu/drm/virtio/virtgpu_gem.c b/drivers/gpu/drm/virtio/virtgpu_gem.c
    > index 580a78809836..7db48d17ee3a 100644
    > --- a/drivers/gpu/drm/virtio/virtgpu_gem.c
    > +++ b/drivers/gpu/drm/virtio/virtgpu_gem.c
    > @@ -228,8 +228,10 @@ int virtio_gpu_array_lock_resv(struct virtio_gpu_object_array *objs)
    >
    > for (i = 0; i < objs->nents; ++i) {
    > ret = dma_resv_reserve_fences(objs->objs[i]->resv, 1);
    > - if (ret)
    > + if (ret) {
    > + virtio_gpu_array_unlock_resv(objs);
    > return ret;
    > + }
    > }
    > return ret;
    > }

    \
     
     \ /
      Last update: 2022-06-29 08:44    [W:4.152 / U:0.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site