lkml.org 
[lkml]   [2022]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v5 09/19] arch_topology: Use the last level cache information from the cacheinfo
    Date
    On 29/06/2022 19:42, Sudeep Holla wrote:
    > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
    >
    > On Wed, Jun 29, 2022 at 06:18:25PM +0000, Conor.Dooley@microchip.com wrote:
    >>
    >> No, no it doesn't. Not sure what I was thinking there.
    >> Prob tested that on the the last commit that bisect tested
    >> rather than the one it pointed out the problem was with.
    >>
    >> Either way, boot is broken in -next.
    >>
    >
    > Can you check if the below fixes the issue?

    Unfortunately, no joy.
    Applied to a HEAD of 3b23bb2573e6 ("arch_topology: Use the
    last level cache information from the cacheinfo").
    Thanks,
    Conor.

    > Assuming presenting L1 as
    > LLC might be causing issue.
    >
    > Regards,
    > Sudeep
    >
    > -->8
    > diff --git i/drivers/base/cacheinfo.c w/drivers/base/cacheinfo.c
    > index 167abfa6f37d..a691317f7fdd 100644
    > --- i/drivers/base/cacheinfo.c
    > +++ w/drivers/base/cacheinfo.c
    > @@ -60,7 +60,8 @@ bool last_level_cache_is_valid(unsigned int cpu)
    >
    > llc = per_cpu_cacheinfo_idx(cpu, cache_leaves(cpu) - 1);
    >
    > - return (llc->attributes & CACHE_ID) || !!llc->fw_token;
    > + return (llc->type == CACHE_TYPE_UNIFIED) &&
    > + ((llc->attributes & CACHE_ID) || !!llc->fw_token);
    >
    > }
    >
    \
     
     \ /
      Last update: 2022-06-29 21:41    [W:3.229 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site