lkml.org 
[lkml]   [2022]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 08/22] devfreq: shut up kernel-doc warnings
From
On 22. 6. 28. 18:46, Mauro Carvalho Chehab wrote:
> There are 4 warnings there:
> drivers/devfreq/devfreq.c:707: warning: Function parameter or member 'val' not described in 'qos_min_notifier_call'
> drivers/devfreq/devfreq.c:707: warning: Function parameter or member 'ptr' not described in 'qos_min_notifier_call'
> drivers/devfreq/devfreq.c:717: warning: Function parameter or member 'val' not described in 'qos_max_notifier_call'
> drivers/devfreq/devfreq.c:717: warning: Function parameter or member 'ptr' not described in 'qos_max_notifier_call'
>
> It turns that neither val nor ptr are actually used on those
> function, so document as such.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
> ---
>
> To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover.
> See [PATCH 00/22] at: https://lore.kernel.org/all/cover.1656409369.git.mchehab@kernel.org/
>
> drivers/devfreq/devfreq.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
> index 01474daf4548..3020855d8400 100644
> --- a/drivers/devfreq/devfreq.c
> +++ b/drivers/devfreq/devfreq.c
> @@ -700,6 +700,8 @@ static int qos_notifier_call(struct devfreq *devfreq)
> /**
> * qos_min_notifier_call() - Callback for QoS min_freq changes.
> * @nb: Should be devfreq->nb_min
> + * @val: not used
> + * @ptr: not used
> */
> static int qos_min_notifier_call(struct notifier_block *nb,
> unsigned long val, void *ptr)
> @@ -710,6 +712,8 @@ static int qos_min_notifier_call(struct notifier_block *nb,
> /**
> * qos_max_notifier_call() - Callback for QoS max_freq changes.
> * @nb: Should be devfreq->nb_max
> + * @val: not used
> + * @ptr: not used
> */
> static int qos_max_notifier_call(struct notifier_block *nb,
> unsigned long val, void *ptr)

Applied it. Thanks.

--
Best Regards,
Samsung Electronics
Chanwoo Choi

\
 
 \ /
  Last update: 2022-06-29 21:32    [W:0.163 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site