Messages in this thread Patch in this message | | | Date | Wed, 29 Jun 2022 19:42:17 +0100 | From | Sudeep Holla <> | Subject | Re: [PATCH v5 09/19] arch_topology: Use the last level cache information from the cacheinfo |
| |
On Wed, Jun 29, 2022 at 06:18:25PM +0000, Conor.Dooley@microchip.com wrote: > > No, no it doesn't. Not sure what I was thinking there. > Prob tested that on the the last commit that bisect tested > rather than the one it pointed out the problem was with. > > Either way, boot is broken in -next. >
Can you check if the below fixes the issue ? Assuming presenting L1 as LLC might be causing issue.
Regards, Sudeep
-->8 diff --git i/drivers/base/cacheinfo.c w/drivers/base/cacheinfo.c index 167abfa6f37d..a691317f7fdd 100644 --- i/drivers/base/cacheinfo.c +++ w/drivers/base/cacheinfo.c @@ -60,7 +60,8 @@ bool last_level_cache_is_valid(unsigned int cpu)
llc = per_cpu_cacheinfo_idx(cpu, cache_leaves(cpu) - 1);
- return (llc->attributes & CACHE_ID) || !!llc->fw_token; + return (llc->type == CACHE_TYPE_UNIFIED) && + ((llc->attributes & CACHE_ID) || !!llc->fw_token);
}
| |