lkml.org 
[lkml]   [2022]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH stable 5.4 11/11] crypto: arm/ghash-ce - define fpu before fpu registers are referenced
    Date
    From: Stefan Agner <stefan@agner.ch>

    commit 7548bf8c17d84607c106bd45d81834afd95a2edb upstream

    Building ARMv7 with Clang's integrated assembler leads to errors such
    as:
    arch/arm/crypto/ghash-ce-core.S:34:11: error: register name expected
    t3l .req d16
    ^

    Since no FPU has selected yet Clang considers d16 not a valid register.
    Moving the FPU directive on-top allows Clang to parse the registers and
    allows to successfully build this file with Clang's integrated assembler.

    Signed-off-by: Stefan Agner <stefan@agner.ch>
    Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
    Tested-by: Nick Desaulniers <ndesaulniers@google.com>
    Acked-by: Ard Biesheuvel <ardb@kernel.org>
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
    ---
    arch/arm/crypto/ghash-ce-core.S | 5 +++--
    1 file changed, 3 insertions(+), 2 deletions(-)

    diff --git a/arch/arm/crypto/ghash-ce-core.S b/arch/arm/crypto/ghash-ce-core.S
    index 534c9647726d..9f51e3fa4526 100644
    --- a/arch/arm/crypto/ghash-ce-core.S
    +++ b/arch/arm/crypto/ghash-ce-core.S
    @@ -8,6 +8,9 @@
    #include <linux/linkage.h>
    #include <asm/assembler.h>

    + .arch armv8-a
    + .fpu crypto-neon-fp-armv8
    +
    SHASH .req q0
    T1 .req q1
    XL .req q2
    @@ -88,8 +91,6 @@
    T3_H .req d17

    .text
    - .arch armv8-a
    - .fpu crypto-neon-fp-armv8

    .macro __pmull_p64, rd, rn, rm, b1, b2, b3, b4
    vmull.p64 \rd, \rn, \rm
    --
    2.25.1
    \
     
     \ /
      Last update: 2022-06-29 20:04    [W:2.752 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site