lkml.org 
[lkml]   [2022]   [Jun]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] driver: pca953x: avoid error message when resuming
On Mon, Jun 20, 2022 at 6:03 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Mon, Jun 20, 2022 at 4:18 PM Pierluigi Passaro
> <pierluigi.p@variscite.com> wrote:

> > > > Avoids the error messages "pca953x 1-0020: failed reading register"
> > > > when resuming from suspend using gpio-key attached to pca9534.
> > > Thanks for your report and fix. My comments below.
> > > First of all, how many of them do you get and why is it a problem?
> >
> > The number of occurrences depends on the time required to I2C bus to fully wake-up.
> > It's not a real problem, but the message may lead to think about a real I2C problem.
>
> Wolfram, do we have any mechanisms that guarantees that I2C traffic is
> not going on a semi-woken up host controller?
>
> Writing this, I'm in doubt this patch is a fix we want. Wouldn't it
> just hide the real issue with some resume ordering?

That sounds like a bug in the pm routines in the I2C driver. Why is it
returning from [runtime_]resume() if it is not properly resumed?

Yours,
Linus Walleij

\
 
 \ /
  Last update: 2022-06-28 14:36    [W:0.058 / U:0.648 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site