Messages in this thread | | | Date | Tue, 28 Jun 2022 14:20:04 +0200 | From | Greg KH <> | Subject | Re: [PATCH v2 00/12] Adding Gaudi2 ASIC support to habanalabs driver |
| |
On Tue, Jun 28, 2022 at 01:59:46PM +0300, Oded Gabbay wrote: > I'm sending the v2 of this patch-set after fixing some comments from Greg. > > Changes to each patch are detailed in the relevant patches. > > Patch 6 was added to remove obsolete elements from the device structure. > > Patch 11 in the 1st patch-set, the TPM patch, was removed due to some points > that Greg raised and I need to investigate and come back with answers. > > Original cover-letter: > > This patch-set adds support for initializing and sending workloads to > habanalabs next-gen deep-learning training accelerator ASIC, called Gaudi2. > > The Gaudi2 ASIC is based on the same architecture as the Gaudi ASIC and > therefore, the driver's common code is applicable to it with only a few > changes. Almost all of the code included in this patch-set is the > ASIC-depedent code which is different per ASIC. > > The patches details are as follows: > > - Patch 1 adds the necessary registers header files. I took great care of > reducing this amount to minimum. > > - Patch 2 adds the Gaudi2 definitions to the uapi file. > > - Patch 3 adds the bulk of the Gaudi2 asic-specific code. > > - Patches 4-6 modify the existing code to initialize the new asic-specific > functions and properties and to remove unused elements. > > - Patch 7 adds a generic security module that will be used by Gaudi2, and > future ASICs, to initialize the security mechanisms of the device in a > common way. > > - Patches 8-11 add various features of Gaudi2 in asic-specific and common code. > > - Patch 12 enables the Gaudi2 code in the driver. > > More details on Gaudi2 Hardware can be found here: > https://habana.ai/wp-content/uploads/pdf/2022/gaudi2-whitepaper.pdf > > We have already uploaded the updated LLVM compiler for our TPC engine to: > https://github.com/HabanaAI/tpc_llvm/tree/v1.1.0 > > And we are currently working on updating the open-source SynapseAI Core to > submit workloads to Gaudi2 via the driver.
Look good to me, thanks for the changes!
greg k-h
| |