lkml.org 
[lkml]   [2022]   [Jun]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2] soc: mediatek: Introduce mediatek-regulator-coupler driver
From
Hi Angelo,

On 6/28/22 14:01, AngeloGioacchino Del Regno wrote:
> + mrc->vsram_rdev = rdev;
> + } else if (!strstr(rdev_name, "vgpu") && !strstr(rdev_name, "Vgpu"))
> + return 1;

Nit: checkpatch --strict should warn about the missing {} here. In
general braces are always needed for each condition if they were needed
once in the if-else.

Reviewed-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>

--
Best regards,
Dmitry

\
 
 \ /
  Last update: 2022-06-28 13:50    [W:0.029 / U:0.612 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site