Messages in this thread | | | Date | Tue, 28 Jun 2022 14:49:06 +0300 | Subject | Re: [PATCH v2] soc: mediatek: Introduce mediatek-regulator-coupler driver | From | Dmitry Osipenko <> |
| |
Hi Angelo,
On 6/28/22 14:01, AngeloGioacchino Del Regno wrote: > + mrc->vsram_rdev = rdev; > + } else if (!strstr(rdev_name, "vgpu") && !strstr(rdev_name, "Vgpu")) > + return 1;
Nit: checkpatch --strict should warn about the missing {} here. In general braces are always needed for each condition if they were needed once in the if-else.
Reviewed-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
-- Best regards, Dmitry
| |