Messages in this thread | | | From | Andy Shevchenko <> | Date | Tue, 28 Jun 2022 13:39:03 +0200 | Subject | Re: [PATCH] serial: mvebu: Apply old baudrate to termios |
| |
On Tue, Jun 28, 2022 at 12:01 PM Pali Rohár <pali@kernel.org> wrote: > On Tuesday 28 June 2022 11:51:36 Pali Rohár wrote: > > On Tuesday 28 June 2022 12:41:55 Ilpo Järvinen wrote:
> > > A fallback baud rate was derived from old termios but got never applied > > > to (new/current) termios. Old termios is dropped once ->set_termios() > > > call chain completes, only termios persists the values. Encode also the > > > old baud rate into termios. > > > > > > Fixes: 68a0db1d7da2 ("serial: mvebu-uart: add function to change baudrate") > > > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> > > > > Hello! Could you explain a bit more what is this patch fixing? I have > > not caught it yet. Do you have a test scenario which can demonstrate > > this issue? Because I have tested this driver more deeply (on Mox > > and Espressobin) and I have not seen any remaining issue with reporting > > incorrect baudrate. > > Ou, now I see where is the issue. Patch which I tested and which fixes > reporting baudrate is not in kernel tree yet and it looks like I totally > forgot to sent it to ML. I will send it. Sorry for confusion.
Shouldn't the Ilpo's applied anyway to fix the current code base?
-- With Best Regards, Andy Shevchenko
| |