Messages in this thread | | | Date | Tue, 28 Jun 2022 07:57:12 +0300 | From | Tony Lindgren <> | Subject | Re: [PATCH] arm/mach-omap2: Fix refcount leak bug in omap_hwmod.c |
| |
Hi,
* Liang He <windhl@126.com> [220618 04:43]: > In _init(), of_find_node_by_name() will return a node pointer with > refcount incremented. We should use of_node_put() in fail path or > when it is not used anymore. > > NOTE: As the ref will be passed from 'bus' to 'np' by the xx_lookup(), > in normal exit path, we should call of_node_put() at the end use of 'np', > not the end use of 'bus'.
Looks correct to me. What about missing of_node_put() for of_get_next_child() also in the _init() function?
Regards,
Tony
| |