Messages in this thread | | | From | "Tian, Kevin" <> | Subject | RE: [PATCH] vfio: Fix memory leaks in vfio_create_group() | Date | Wed, 29 Jun 2022 02:20:56 +0000 |
| |
> From: Rao, Lei <lei.rao@intel.com> > Sent: Wednesday, June 29, 2022 10:05 AM > > If an error occurs after vfio_group_alloc(), we need to release the > group. > > Signed-off-by: Lei Rao <lei.rao@intel.com> > --- > drivers/vfio/vfio.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/vfio/vfio.c b/drivers/vfio/vfio.c > index 61e71c1154be..2460aec44a6d 100644 > --- a/drivers/vfio/vfio.c > +++ b/drivers/vfio/vfio.c > @@ -414,6 +414,7 @@ static struct vfio_group *vfio_create_group(struct > iommu_group *iommu_group, > mutex_unlock(&vfio.group_lock); > err_put: > put_device(&group->dev); > + vfio_group_release(&group->dev);
this is called automatically by put_device().
> return ret; > } > > -- > 2.32.0
| |