lkml.org 
[lkml]   [2022]   [Jun]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 1/8] watchdog: bcm7038_wdt: Remove #ifdef guards for PM related functions
    From
    On 6/28/22 12:34, Paul Cercueil wrote:
    > Use the new DEFINE_SIMPLE_DEV_PM_OPS() and pm_sleep_ptr() macros to
    > handle the .suspend/.resume callbacks.
    >
    > These macros allow the suspend and resume functions to be automatically
    > dropped by the compiler when CONFIG_SUSPEND is disabled, without having
    > to use #ifdef guards. Not using #ifdef guards means that the code is
    > always compiled independently of any Kconfig option, and thanks to that
    > bugs and regressions are easier to catch.
    >
    > Signed-off-by: Paul Cercueil <paul@crapouillou.net>
    > Cc: Florian Fainelli <f.fainelli@gmail.com>
    > Cc: Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com>

    Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
    Tested-by: Florian Fainelli <f.fainelli@gmail.com>

    Confirmed that the exact same code is generated before/after, thanks Paul!
    --
    Florian

    \
     
     \ /
      Last update: 2022-06-28 22:16    [W:3.350 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site