Messages in this thread | | | Date | Tue, 28 Jun 2022 13:09:58 -0700 | Subject | Re: [PATCH 1/8] watchdog: bcm7038_wdt: Remove #ifdef guards for PM related functions | From | Florian Fainelli <> |
| |
On 6/28/22 12:34, Paul Cercueil wrote: > Use the new DEFINE_SIMPLE_DEV_PM_OPS() and pm_sleep_ptr() macros to > handle the .suspend/.resume callbacks. > > These macros allow the suspend and resume functions to be automatically > dropped by the compiler when CONFIG_SUSPEND is disabled, without having > to use #ifdef guards. Not using #ifdef guards means that the code is > always compiled independently of any Kconfig option, and thanks to that > bugs and regressions are easier to catch. > > Signed-off-by: Paul Cercueil <paul@crapouillou.net> > Cc: Florian Fainelli <f.fainelli@gmail.com> > Cc: Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> Tested-by: Florian Fainelli <f.fainelli@gmail.com>
Confirmed that the exact same code is generated before/after, thanks Paul! -- Florian
| |