Messages in this thread | | | From | Andy Shevchenko <> | Date | Tue, 28 Jun 2022 22:06:51 +0200 | Subject | Re: [PATCH 3/4] serial: 8250_dw: Move 16550 compatible & LCR checks to dw8250_verify_write() |
| |
On Tue, Jun 28, 2022 at 3:43 PM Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> wrote: > > Rename dw8250_check_lcr() -> dw8250_verify_write() and add comment. > Move LCR and 16550_compatible checks there. As offset is now passed and > dw8250_verify_write() ensures it's UART_LCR, offset can use used > instead of explicit UART_LCR.
...
> +/* > + * DW UART can be configured to indicate BUSY in USR (with > + * UART_16550_COMPATIBLE=NO or version prior to introducing that option). > + * If BUSY is set while writing to LCR register, the write is ignored and > + * needs to be retries.
retried
> + */
-- With Best Regards, Andy Shevchenko
| |