Messages in this thread | | | Date | Tue, 28 Jun 2022 08:34:06 +0200 | From | Greg KH <> | Subject | Re: [PATCH 04/12] habanalabs: add unsupported functions |
| |
On Mon, Jun 27, 2022 at 11:26:12PM +0300, Oded Gabbay wrote: > There are a number of new ASIC-specific functions that were added > for Gaudi2. To make the common code work, we need to define empty > implementations of those functions for Goya and Gaudi. > > Some functions will return error if called with Goya/Gaudi. > > Signed-off-by: Oded Gabbay <ogabbay@kernel.org> > --- > drivers/misc/habanalabs/gaudi/gaudi.c | 24 ++++++++++++++++++++++++ > drivers/misc/habanalabs/goya/goya.c | 24 ++++++++++++++++++++++++ > 2 files changed, 48 insertions(+) > > diff --git a/drivers/misc/habanalabs/gaudi/gaudi.c b/drivers/misc/habanalabs/gaudi/gaudi.c > index ae894335e9f8..f4581220ecd5 100644 > --- a/drivers/misc/habanalabs/gaudi/gaudi.c > +++ b/drivers/misc/habanalabs/gaudi/gaudi.c > @@ -8588,6 +8588,11 @@ static void gaudi_ctx_fini(struct hl_ctx *ctx) > gaudi_internal_cb_pool_fini(ctx->hdev, ctx); > } > > +int gaudi_pre_schedule_cs(struct hl_cs *cs) > +{ > + return 0; > +}
static?
Did you run sparse on this change?
thanks,
greg k-h
| |