Messages in this thread | | | Date | Tue, 28 Jun 2022 21:13:53 +0200 | Subject | Re: [PATCH] i2c: cadence: Unregister the clk notifier in error path | From | Lars-Peter Clausen <> |
| |
On 6/28/22 21:12, Satish Nagireddy wrote: > This patch ensures that the clock notifier is unregistered > when driver probe is returning error. > > Signed-off-by: Satish Nagireddy <satish.nagireddy@getcruise.com>
Thanks! Looks good.
Tested-by: Lars-Peter Clausen <lars@metafoo.de>
> --- > drivers/i2c/busses/i2c-cadence.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/i2c/busses/i2c-cadence.c b/drivers/i2c/busses/i2c-cadence.c > index b4c1ad19cdae..3d6f8ee355bf 100644 > --- a/drivers/i2c/busses/i2c-cadence.c > +++ b/drivers/i2c/busses/i2c-cadence.c > @@ -1338,6 +1338,7 @@ static int cdns_i2c_probe(struct platform_device *pdev) > return 0; > > err_clk_dis: > + clk_notifier_unregister(id->clk, &id->clk_rate_change_nb); > clk_disable_unprepare(id->clk); > pm_runtime_disable(&pdev->dev); > pm_runtime_set_suspended(&pdev->dev);
| |