lkml.org 
[lkml]   [2022]   [Jun]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] ata: pata_cs5535: Fix W=1 warnings
From
Date
On 6/28/22 1:05 PM, Sergey Shtylyov wrote:
[...]
>>> x86_64 allmodconfig build with W=1 gives these warnings:
>>>
>>> drivers/ata/pata_cs5535.c: In function ‘cs5535_set_piomode’:
>>> drivers/ata/pata_cs5535.c:93:11: error: variable ‘dummy’ set but not used [-Werror=unused-but-set-variable]
>>> u32 reg, dummy;
>>> ^~~~~
>>> drivers/ata/pata_cs5535.c: In function ‘cs5535_set_dmamode’:
>>> drivers/ata/pata_cs5535.c:132:11: error: variable ‘dummy’ set but not used [-Werror=unused-but-set-variable]
>>> u32 reg, dummy;
>>> ^~~~~
>>> cc1: all warnings being treated as errors
>>>
>>> Mark variables 'dummy' as "maybe unused" to satisfy when rdmsr() is
>>> stubbed, which is the same as what we already do in pata_cs5536.c .

Wait, what do you mean by "stubbed", the version in <asm/paravirt.h>?

>>>
>>> Signed-off-by: John Garry <john.garry@huawei.com>
>
> Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>

[...]

MBR, Sergey

\
 
 \ /
  Last update: 2022-06-28 20:40    [W:0.103 / U:0.424 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site