lkml.org 
[lkml]   [2022]   [Jun]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] sched/core: add forced idle accounting for cgroups
Hello,

On Mon, Jun 27, 2022 at 03:35:21PM -0700, Josh Don wrote:
> > Would it make sense to namespace the name to reflect the fact that
> > this is tied to core scheduling? e.g. something like
> > core.force_idle_usec (and yeah, underscore between words, please). I
> > kinda hate that the feature is named "core". The word is so
> > overloaded.
>
> Sure, although a namespace of "core_sched" would be a bit clearer,
> since as you point out "core" is pretty overloaded :)

Yeah, core_sched is probabaly better and hopefully it'll get better as
we get used to the name.

> Lack of underscore for forceidle was to be consistent with
> "core_forceidle_sum" being dumped from /proc/pid/sched, but I'm fine
> with it either way.
>
> So,
>
> core_sched.force_idle_usec ?

Yeah, that'd be my preference.

Thanks.

--
tejun

\
 
 \ /
  Last update: 2022-06-28 19:58    [W:0.040 / U:1.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site