lkml.org 
[lkml]   [2022]   [Jun]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v5 02/12] can: slcan: use netdev helpers to print out messages
    Date
    Replace printk() calls with corresponding netdev helpers.

    Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
    ---

    (no changes since v1)

    drivers/net/can/slcan.c | 5 ++---
    1 file changed, 2 insertions(+), 3 deletions(-)

    diff --git a/drivers/net/can/slcan.c b/drivers/net/can/slcan.c
    index b37d35c2a23a..6162a9c21672 100644
    --- a/drivers/net/can/slcan.c
    +++ b/drivers/net/can/slcan.c
    @@ -365,7 +365,7 @@ static netdev_tx_t slc_xmit(struct sk_buff *skb, struct net_device *dev)
    spin_lock(&sl->lock);
    if (!netif_running(dev)) {
    spin_unlock(&sl->lock);
    - printk(KERN_WARNING "%s: xmit: iface is down\n", dev->name);
    + netdev_warn(dev, "xmit: iface is down\n");
    goto out;
    }
    if (sl->tty == NULL) {
    @@ -776,8 +776,7 @@ static void __exit slcan_exit(void)

    sl = netdev_priv(dev);
    if (sl->tty) {
    - printk(KERN_ERR "%s: tty discipline still running\n",
    - dev->name);
    + netdev_err(dev, "tty discipline still running\n");
    }

    unregister_netdev(dev);
    --
    2.32.0
    \
     
     \ /
      Last update: 2022-06-28 18:36    [W:3.119 / U:0.500 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site