lkml.org 
[lkml]   [2022]   [Jun]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next v9 15/16] ARM: dts: r9a06g032-rzn1d400-db: add switch description
Le Tue, 28 Jun 2022 17:34:31 +0200,
Geert Uytterhoeven <geert@linux-m68k.org> a écrit :

> > +&gmac2 {
>
> Please keep the nodes sorted (everywhere).

Arg sorry, again, the previous nodes seems not to be ordered.
I'll be more careful next time.

>
> > +&pinctrl{
> > + pins_mdio1: pins_mdio1 {
> > + pinmux = <
> > + RZN1_PINMUX(152, RZN1_FUNC_MDIO1_SWITCH)
> > + RZN1_PINMUX(153, RZN1_FUNC_MDIO1_SWITCH)
> > + >;
>
> This is not a single value, but an array of 2 values. Hence they
> should be grouped using angular brackets, to enable automatic
> validation.

Good to know, noted for next time.

>
> I will fix the above while applying, so no need to resend.

Thanks Geert,

Clément

>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> i.e. will queue in renesas-devel for v5.20.
>
> Gr{oetje,eeting}s,
>
> Geert


--
Clément Léger,
Embedded Linux and Kernel engineer at Bootlin
https://bootlin.com

\
 
 \ /
  Last update: 2022-06-28 18:31    [W:0.063 / U:0.484 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site