Messages in this thread | | | Date | Tue, 28 Jun 2022 09:10:27 -0700 | From | Jakub Kicinski <> | Subject | Re: [PATCH net-next v1 2/3] net: dsa: ar9331: add support for pause stats |
| |
On Tue, 28 Jun 2022 10:45:04 +0200 Oleksij Rempel wrote: > After I started investigating this topic, I was really frustrated. It is > has hard to find what is wrong: my patch is not working and flow > controller is not triggered? Or every HW/driver implements counters in > some own way. Same is about byte counts: for same packet with different > NICs i have at least 3 different results: 50, 64 and 68. > It makes testing and validation a nightmare.
Yeah, I was gonna mention QA in my reply. The very practical reason I've gone no-CRC, no-flow control in the driver stats in the past was that it made it possible to test the counters are correct and the match far end. I mean SW matches HW, and they both match between sender/receiver (testing NIC-switch-NIC if either link does flow control the counters on NICs won't match).
| |