Messages in this thread | | | From | HORIGUCHI NAOYA(堀口 直也) <> | Subject | Re: [PATCH v2 7/9] mm, hwpoison: make __page_handle_poison returns int | Date | Tue, 28 Jun 2022 06:02:26 +0000 |
| |
On Mon, Jun 27, 2022 at 05:02:47PM +0800, Miaohe Lin wrote: > On 2022/6/24 7:51, Naoya Horiguchi wrote: > > From: Naoya Horiguchi <naoya.horiguchi@nec.com> > > > > __page_handle_poison() returns bool that shows whether > > take_page_off_buddy() has passed or not now. But we will want to > > distinguish another case of "dissolve has passed but taking off failed" > > by its return value. So change the type of the return value. > > No functional change. > > > > Signed-off-by: Naoya Horiguchi <naoya.horiguchi@nec.com> > > --- ... > > @@ -1698,8 +1704,7 @@ static int try_memory_failure_hugetlb(unsigned long pfn, int flags, int *hugetlb > > */ > > if (res == 0) { > > unlock_page(head); > > - res = MF_FAILED; > > It seems the previous discussion in [1] is missed. But that doesn't matter as pointed out by [1]. :)
Sorry for missing this, I updated this line to be removed in patch 8/9.
> > Reviewed-by: Miaohe Lin <linmiaohe@huawei.com>
Thank you.
- Naoya Horiguchi
> > Thanks. > > [1]: https://lkml.org/lkml/2022/6/8/10 | |