lkml.org 
[lkml]   [2022]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 166/181] ARM: exynos: Fix refcount leak in exynos_map_pmu
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    commit c4c79525042a4a7df96b73477feaf232fe44ae81 upstream.

    of_find_matching_node() returns a node pointer with refcount
    incremented, we should use of_node_put() on it when not need anymore.
    Add missing of_node_put() to avoid refcount leak.
    of_node_put() checks null pointer.

    Fixes: fce9e5bb2526 ("ARM: EXYNOS: Add support for mapping PMU base address via DT")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Link: https://lore.kernel.org/r/20220523145513.12341-1-linmq006@gmail.com
    Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    arch/arm/mach-exynos/exynos.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/arch/arm/mach-exynos/exynos.c
    +++ b/arch/arm/mach-exynos/exynos.c
    @@ -149,6 +149,7 @@ static void exynos_map_pmu(void)
    np = of_find_matching_node(NULL, exynos_dt_pmu_match);
    if (np)
    pmu_base_addr = of_iomap(np, 0);
    + of_node_put(np);
    }

    static void __init exynos_init_irq(void)

    \
     
     \ /
      Last update: 2022-06-27 14:00    [W:4.163 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site