lkml.org 
[lkml]   [2022]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] erofs: Wake up all waiters after z_erofs_lzma_head ready.
On Mon, Jun 27, 2022 at 01:57:54PM +0800, Yue Hu wrote:
> On Sat, 25 Jun 2022 22:50:00 +0800
> Yuwen Chen <chenyuwen1@meizu.com> wrote:
>

...

> >
> > Signed-off-by: Yuwen Chen <chenyuwen1@meizu.com>
> > ---
> > fs/erofs/decompressor_lzma.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/fs/erofs/decompressor_lzma.c b/fs/erofs/decompressor_lzma.c
> > index 05a3063cf2bc..5e59b3f523eb 100644
> > --- a/fs/erofs/decompressor_lzma.c
> > +++ b/fs/erofs/decompressor_lzma.c
> > @@ -143,6 +143,7 @@ int z_erofs_load_lzma_config(struct super_block *sb,
> > DBG_BUGON(z_erofs_lzma_head);
> > z_erofs_lzma_head = head;
> > spin_unlock(&z_erofs_lzma_lock);
> > + wake_up_all(&z_erofs_lzma_wq);
> >
> > z_erofs_lzma_max_dictsize = dict_size;
> > mutex_unlock(&lzma_resize_mutex);
>
> Please do not end the summary line(title) with a period.

Okay, that is a good point, also it'd be better to de-capitalize the 'W'
in "Wake" since they are common practices for kernel patches.

If it's convenient to you to send another version, please go with my
r-v-b tag.

Thanks,
Gao Xiang

\
 
 \ /
  Last update: 2022-06-27 08:16    [W:0.063 / U:0.340 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site