lkml.org 
[lkml]   [2022]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 114/181] s390/crash: make copy_oldmem_page() return number of bytes copied
    Date
    From: Alexander Gordeev <agordeev@linux.ibm.com>

    [ Upstream commit af2debd58bd769e38f538143f0d332e15d753396 ]

    Callback copy_oldmem_page() returns either error code or zero.
    Instead, it should return the error code or number of bytes copied.

    Fixes: df9694c7975f ("s390/dump: streamline oldmem copy functions")
    Reviewed-by: Alexander Egorenkov <egorenar@linux.ibm.com>
    Tested-by: Alexander Egorenkov <egorenar@linux.ibm.com>
    Signed-off-by: Alexander Gordeev <agordeev@linux.ibm.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    arch/s390/kernel/crash_dump.c | 7 ++++---
    1 file changed, 4 insertions(+), 3 deletions(-)

    --- a/arch/s390/kernel/crash_dump.c
    +++ b/arch/s390/kernel/crash_dump.c
    @@ -233,9 +233,10 @@ ssize_t copy_oldmem_page(struct iov_iter
    rc = copy_oldmem_user(iter->iov->iov_base, src, csize);
    else
    rc = copy_oldmem_kernel(iter->kvec->iov_base, src, csize);
    - if (!rc)
    - iov_iter_advance(iter, csize);
    - return rc;
    + if (rc < 0)
    + return rc;
    + iov_iter_advance(iter, csize);
    + return csize;
    }

    /*

    \
     
     \ /
      Last update: 2022-06-27 13:56    [W:4.070 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site