lkml.org 
[lkml]   [2022]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 085/181] ice: ignore protocol field in GTP offload
    Date
    From: Marcin Szycik <marcin.szycik@linux.intel.com>

    [ Upstream commit d4ea6f6373ef56d1d795a24f1f5874f4a6019199 ]

    Commit 34a897758efe ("ice: Add support for inner etype in switchdev")
    added the ability to match on inner ethertype. A side effect of that change
    is that it is now impossible to add some filters for protocols which do not
    contain inner ethtype field. tc requires the protocol field to be specified
    when providing certain other options, e.g. src_ip. This is a problem in
    case of GTP - when user wants to specify e.g. src_ip, they also need to
    specify protocol in tc command (otherwise tc fails with: Illegal "src_ip").
    Because GTP is a tunnel, the protocol field is treated as inner protocol.
    GTP does not contain inner ethtype field and the filter cannot be added.

    To fix this, ignore the ethertype field in case of GTP filters.

    Fixes: 9a225f81f540 ("ice: Support GTP-U and GTP-C offload in switchdev")
    Signed-off-by: Marcin Szycik <marcin.szycik@linux.intel.com>
    Tested-by: Sandeep Penigalapati <sandeep.penigalapati@intel.com>
    Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/intel/ice/ice_tc_lib.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/intel/ice/ice_tc_lib.c b/drivers/net/ethernet/intel/ice/ice_tc_lib.c
    index 3acd9f921c44..734bfa121e24 100644
    --- a/drivers/net/ethernet/intel/ice/ice_tc_lib.c
    +++ b/drivers/net/ethernet/intel/ice/ice_tc_lib.c
    @@ -994,7 +994,9 @@ ice_parse_cls_flower(struct net_device *filter_dev, struct ice_vsi *vsi,
    n_proto_key = ntohs(match.key->n_proto);
    n_proto_mask = ntohs(match.mask->n_proto);

    - if (n_proto_key == ETH_P_ALL || n_proto_key == 0) {
    + if (n_proto_key == ETH_P_ALL || n_proto_key == 0 ||
    + fltr->tunnel_type == TNL_GTPU ||
    + fltr->tunnel_type == TNL_GTPC) {
    n_proto_key = 0;
    n_proto_mask = 0;
    } else {
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-27 13:55    [W:4.070 / U:0.284 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site