Messages in this thread | | | From | Yangxi Xiang <> | Subject | Re: [PATCH] vt: fix memory overlapping when deleting chars in the buffer | Date | Mon, 27 Jun 2022 19:40:16 +0800 |
| |
> And what commit id does this fix, or has it always been broken?
It fixes the commit 81732c3 (tty vt: Fix line garbage in virtual console on command line edition). The line buffer is not always broken, because the memcpy utilized the hardware acceleration, whose result is not deterministic. I fix this issue by replacing the scr_memcpyw with scr_memmovew used in insert_char, and preserving the memcpy optimization when the buffers are not overlapping.
Yangxi Xiang
| |